From: Jan Engelhardt Date: Thu, 20 Apr 2017 16:25:49 +0200 Subject: build: remove calling untrusted hooks Avoid downloading untrusted executables and wasting time with a sysroot. License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html --- DEPS | 127 +---------------------------------------------------------- 1 file changed, 2 insertions(+), 125 deletions(-) diff --git a/DEPS b/DEPS --- a/DEPS +++ b/DEPS @@ -119,7 +119,7 @@ vars = { # Check out and download nacl by default, unless on an arm mac. # This can be disabled e.g. with custom_vars. - 'checkout_nacl': 'not (host_os == "mac" and host_cpu == "arm64")', + 'checkout_nacl': False, # By default, do not check out src-internal. This can be overridden e.g. with # custom_vars. @@ -176,7 +176,7 @@ vars = { # platforms, but support for other platforms may be added in the future. 'checkout_openxr' : 'checkout_win or checkout_android', - 'checkout_instrumented_libraries': 'checkout_linux and checkout_configuration != "small"', + 'checkout_instrumented_libraries': False, # By default bot checkouts the WPR archive files only when this # flag is set True. @@ -4508,54 +4508,6 @@ hooks = [ 'sync', '--extract', ], }, - { - 'name': 'sysroot_arm', - 'pattern': '.', - 'condition': 'checkout_linux and checkout_arm', - 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py', - '--sysroots-json-path=' + Var('sysroots_json_path'), - '--arch=arm'], - }, - { - 'name': 'sysroot_arm64', - 'pattern': '.', - 'condition': 'checkout_linux and checkout_arm64', - 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py', - '--sysroots-json-path=' + Var('sysroots_json_path'), - '--arch=arm64'], - }, - { - 'name': 'sysroot_x86', - 'pattern': '.', - 'condition': 'checkout_linux and (checkout_x86 or checkout_x64)', - 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py', - '--sysroots-json-path=' + Var('sysroots_json_path'), - '--arch=x86'], - }, - { - 'name': 'sysroot_mips', - 'pattern': '.', - 'condition': 'checkout_linux and checkout_mips', - 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py', - '--sysroots-json-path=' + Var('sysroots_json_path'), - '--arch=mips'], - }, - { - 'name': 'sysroot_mips64', - 'pattern': '.', - 'condition': 'checkout_linux and checkout_mips64', - 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py', - '--sysroots-json-path=' + Var('sysroots_json_path'), - '--arch=mips64el'], - }, - { - 'name': 'sysroot_x64', - 'pattern': '.', - 'condition': 'checkout_linux and checkout_x64', - 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py', - '--sysroots-json-path=' + Var('sysroots_json_path'), - '--arch=x64'], - }, { # Case-insensitivity for the Win SDK. Must run before win_toolchain below. 'name': 'ciopfs_linux', @@ -4706,57 +4658,6 @@ hooks = [ ], }, - # Pull clang-format binaries using checked-in hashes. - { - 'name': 'clang_format_win', - 'pattern': '.', - 'condition': 'host_os == "win"', - 'action': [ 'python3', - 'src/third_party/depot_tools/download_from_google_storage.py', - '--no_resume', - '--no_auth', - '--bucket', 'chromium-clang-format', - '-s', 'src/buildtools/win/clang-format.exe.sha1', - ], - }, - { - 'name': 'clang_format_mac_x64', - 'pattern': '.', - 'condition': 'host_os == "mac" and host_cpu == "x64"', - 'action': [ 'python3', - 'src/third_party/depot_tools/download_from_google_storage.py', - '--no_resume', - '--no_auth', - '--bucket', 'chromium-clang-format', - '-s', 'src/buildtools/mac/clang-format.x64.sha1', - '-o', 'src/buildtools/mac/clang-format', - ], - }, - { - 'name': 'clang_format_mac_arm64', - 'pattern': '.', - 'condition': 'host_os == "mac" and host_cpu == "arm64"', - 'action': [ 'python3', - 'src/third_party/depot_tools/download_from_google_storage.py', - '--no_resume', - '--no_auth', - '--bucket', 'chromium-clang-format', - '-s', 'src/buildtools/mac/clang-format.arm64.sha1', - '-o', 'src/buildtools/mac/clang-format', - ], - }, - { - 'name': 'clang_format_linux', - 'pattern': '.', - 'condition': 'host_os == "linux"', - 'action': [ 'python3', - 'src/third_party/depot_tools/download_from_google_storage.py', - '--no_resume', - '--no_auth', - '--bucket', 'chromium-clang-format', - '-s', 'src/buildtools/linux64/clang-format.sha1', - ], - }, # Pull rc binaries using checked-in hashes. { 'name': 'rc_win', @@ -4782,30 +4683,6 @@ hooks = [ '-s', 'src/build/toolchain/win/rc/mac/rc.sha1', ], }, - { - 'name': 'rc_linux', - 'pattern': '.', - 'condition': 'checkout_win and host_os == "linux"', - 'action': [ 'python3', - 'src/third_party/depot_tools/download_from_google_storage.py', - '--no_resume', - '--no_auth', - '--bucket', 'chromium-browser-clang/rc', - '-s', 'src/build/toolchain/win/rc/linux64/rc.sha1', - ] - }, - { - 'name': 'test_fonts', - 'pattern': '.', - 'action': [ 'python3', - 'src/third_party/depot_tools/download_from_google_storage.py', - '--no_resume', - '--extract', - '--no_auth', - '--bucket', 'chromium-fonts', - '-s', 'src/third_party/test_fonts/test_fonts.tar.gz.sha1', - ], - }, # Download test resources for opus, i.e. audio files. { 'name': 'opus_test_files', -- 2.25.1