From: csagan5 <32685696+csagan5@users.noreply.github.com> Date: Thu, 20 Aug 2020 20:15:34 +0200 Subject: Enable darken websites checkbox in themes Unexpire #darken-websites-checkbox-in-themes-setting License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html --- chrome/browser/flag-metadata.json | 6 +++--- components/content_settings/core/common/features.cc | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json --- a/chrome/browser/flag-metadata.json +++ b/chrome/browser/flag-metadata.json @@ -1583,9 +1583,9 @@ "expiry_milestone": 125 }, { - "name": "darken-websites-checkbox-in-themes-setting", - "owners": [ "nemco@google.com", "wenyufu@google.com", "twellington" ], - "expiry_milestone": 125 + "name": "darken-websites-checkbox-in-themes-setting", // this is always enabled in Bromite + "owners": [ "nemco@google.com", "wenyufu@google.com", "twellington" ], // - + "expiry_milestone": -1 }, { "name": "data-retention-policies-disable-sync-types-needed", diff --git a/components/content_settings/core/common/features.cc b/components/content_settings/core/common/features.cc --- a/components/content_settings/core/common/features.cc +++ b/components/content_settings/core/common/features.cc @@ -19,8 +19,8 @@ BASE_FEATURE(kImprovedCookieControls, // Enables auto dark feature in theme settings. #if BUILDFLAG(IS_ANDROID) BASE_FEATURE(kDarkenWebsitesCheckboxInThemesSetting, - "DarkenWebsitesCheckboxInThemesSetting", - base::FEATURE_DISABLED_BY_DEFAULT); + "DarkenWebsitesCheckboxInThemesSetting", // must be enabled + base::FEATURE_ENABLED_BY_DEFAULT); // in Bromite constexpr base::FeatureParam kDarkenWebsitesCheckboxOptOut{ &kDarkenWebsitesCheckboxInThemesSetting, "opt_out", true}; #endif // BUILDFLAG(IS_ANDROID) -- 2.25.1